prettier / prettier/eslint-plugin-prettier
Removing `@types/eslint` as peer dependency
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.7k
- Forks
- 212
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
We (at eslint-plugin-jsdoc) have installed a package (eslint-config-canonical) which depends on eslint-plugin-prettier, but its presence in our dependencies is causing TypeScript errors apparently as a result of your package's inclusion of @types/eslint as a peer dependency.
In ESLint 9, @types/eslint is no longer needed, with ESLint having its own types, and indeed its presence can cause conflicts when other packages are trying to rely on the types of up-to-date ESLint 9.
Would you be able to remove this from peerDependencies? I think ESLint 8 users should be able to still manually install @types/eslint if this is an issue for them.
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the package manifest's peerDependencies entry for @types/eslint and review how the package declares ESLint compatibility. The issue identifies ESLint 8 and 9 as the relevant versions and describes the TypeScript conflict. Done means the unnecessary peer dependency is removed without creating install or type-resolution problems for supported users.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, javascript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100