premake / premake/premake-core
Prebuild commands do not get $(SILENT) in GNU Makefiles
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.6k
- Forks
- 654
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 13
Description
This is a very minor bug but it's a bit annoying: when specifying project-level prebuildcommands, they are added to the Makefile without $(SILENT) (this is neither in the definition of PREBUILDCMDS nor in the target prebuild where this is called.
As far as I can see in the Makefile, this is also the case for prelink commands and postbuild commands, although I didn't test.
Thanks in advance for looking into this!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the GNU Makefile generation code for PREBUILDCMDS and the prebuild target, then inspect how prelink and postbuild commands are emitted. Verify that the affected command paths consistently include $(SILENT) in generated Makefiles, including the untested prelink and postbuild cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100