premake / premake/premake-core

Filter add a feature?

Open
#703 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
3.6k
Forks
654
Avg merge
1d 1h
Merged PRs (30d)
13

Description

today I found out an error.
if use

        symbols 'On'

generate vs2015 files, LNK2019 error appear.
this is solution: https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/
I'll add two library solve it.
like this:

    filter { 'configurations:Debug', 'action:vs2015' }
        -- vs2015 StaticRuntime will add libvcruntimed and libucrtd
        links {
            'libcmtd',
            'libvcruntimed',
            'libucrtd',
        }

if Microsoft vs2017 vs2019 ... or later version using this,
premake solve this issue add internal code?
or premake add later version judgement? like this:

    filter { 'configurations:Debug', 'action:vs2015+' }

maybe this is not best solution.
you know, I may write some Lua code get vs(2015) number, to judge version.
but I think premake add a feature to make us use easy.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the LNK2019 error from the issue with symbols 'On' and the vs2015 action, then inspect the existing filter and Visual Studio action handling. Done means Premake provides a clear way to handle the required VS2015 runtime libraries or supports the proposed version-aware filter behavior for later Visual Studio versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.