premake / premake/premake-core
VS2019 incorrect ExternalIncludePath generation
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.6k
- Forks
- 654
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 13
Description
What seems to be the problem?
Generating VS2019 projects , .vcxproj contains incorrect <ExternalIncludePath> node.
What did you expect to happen?
It shall be <IncludePath> instead.
What have you tried so far?
I've fixed it on my side in file modules/vstudio/vs2010_vcxproj.lua. line 2836
replacing
if _ACTION < "vs2019" then
by
if _ACTION <= "vs2019" then
as Visual Studio 2019 still uses <IncludePath> node.
- Visual Studio 2026 (vs2026)
- Visual Studio 2022 (vs2022)
- Visual Studio 2019 (vs2019)
- Visual Studio 2017 (vs2017)
- Visual Studio 2015 (vs2015)
- Visual Studio 2012 (vs2012)
- Visual Studio 2010 (vs2010)
- Visual Studio 2008 (vs2008)
- Visual Studio 2005 (vs2005)
- GNU Makefile (gmake)
- GNU Makefile Legacy (gmakelegacy)
- XCode (xcode)
- Codelite
- Compile Commands
- Other (Please list below)
What version of Premake are you using?
5.0.0-beta8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open modules/vstudio/vs2010_vcxproj.lua around line 2836 and inspect the Visual Studio version condition that selects the generated XML node. Confirm that VS2019 generation uses IncludePath rather than ExternalIncludePath, then generate a VS2019 project and verify the resulting .vcxproj contains the expected node.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 84/100