premake / premake/premake-core

Files filter only seems to work on source files or header files

Open
#2,157 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

support-request
Dominant language
C
Stars
3.6k
Forks
654
Avg merge
1d 1h
Merged PRs (30d)
13

Description

What are you trying to do?
I'm trying to add an .ico file with buildaction ResourceCompile.

What problem are you having?
I honestly have no idea how to do this, the files filter only seems to work when it has a .cpp or .h extension.

What have you tried so far?

files {
    "%{prj.location}/src/**.h",
    "%{prj.location}/src/**.cpp",

    "%{prj.location}/assets/**.ico"
}

filter "files:%{prj.location}/assets/**.ico"
    buildaction "ResourceCompile"

What version of Premake are you using?
premake5 (Premake Build Script Generator) 5.0.0-beta2

Anything else we should know?
Add any other context about the problem here.
Right now, .ico files have the buildaction set to None in the .vcxproj file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the supplied Lua configuration as the starting case, then inspect the generated .vcxproj entry for the .ico file. Done means the files filter applies ResourceCompile to that entry rather than leaving its buildaction as None.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.