premake / premake/premake-core

targetdir doesn't seem to work on some configurations

Open
#1,969 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.6k
Forks
654
Avg merge
1d 1h
Merged PRs (30d)
13

Description

Discussed in https://github.com/premake/premake-core/discussions/1810

Originally posted by michael-burrowes-ts February 8, 2022
I have a premake file that prepares settings targeting both Windows and Oculus (android) platforms. Everything seems to work properly, except the android config doesn't seem to get the targetdir set for it. In particular, I'm using the vs2019 action, and using both windows and android configs within vs. I'll see "output directory" set properly when I'm on the windows config, but it's not set when I go to the android one. Wondering if this is a known issue? Maybe an artifact of doing a config with "system 'android'" for vs?


The output was disabled as it broke deployment:
https://github.com/premake/premake-core/blob/0078c17a8adacb645b22e03e15204331a8731d9c/modules/android/vsandroid_vcxproj.lua#L634-L642

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked discussion and modules/android/vsandroid_vcxproj.lua around lines 634-642, where output was disabled because it broke deployment. Compare how targetdir is generated for Windows and Android configurations under the vs2019 action, then verify that the Android configuration receives the intended output directory without breaking deployment.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, lua
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.