premake / premake/premake-core

How is includeexternal supposed to work?

Open
#1,245 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.6k
Forks
654
Avg merge
1d 1h
Merged PRs (30d)
13

Description

It would seem to suffer from a lot of edge cases & very little error reporting. If the file included has a workspace of its own there's no error & you end up with an empty work space. We have a master file which goes through a project sub folder looking for premake.lua files. If it finds one it's run with dofile(), these in themselves can have a workspace and reference other premake files from which they want to reference projects. I've found no setup which can easily generate a master workspace with all projects, and workspaces which references these projects. It would be sweet if projects could have multiple workspace parents instead of trying to process the files multiple times & getting the external tags working.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the includeexternal behavior and reproduce the described setup: a master premake.lua using dofile() to load project subfolders, including files with their own workspaces and references. Compare the resulting workspaces with the requested master-and-child workspace relationships; done should include defined behavior for these cases and useful error reporting.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.