premake / premake/premake-core
solution generated for VS2012 (and possibly VS2010) has a slight issue
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.6k
- Forks
- 654
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 13
Description
If I build a standard premake5.lua with "premake5 vs2012", and have a "dependson" directive in one of the projects, an old-style solution dependency is still emitted. The project references you have set up inside of .vcxproj files is sufficient.
The specific code that is generating this is the "premake.vstudio.sln2005.projects" function. The code it calls (sln2005.projectdependencies) needs to be skipped for vs2012 (and possibly vs2010).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at premake.vstudio.sln2005.projects and trace its call to sln2005.projectdependencies for the VS2012 generator. Compare generated solutions for VS2012 and VS2010, then verify that project references remain while the old-style solution dependency is absent where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100