precice / precice/tutorials

Partitioned heat conduction: initialize data for Nutils participants

Open
#306 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
C
Stars
142
Forks
167
Avg merge
20h 24m
Merged PRs (30d)
11

Description

The Nutils participants don't initialize data correctly:

https://github.com/precice/tutorials/blob/017b97cff4a9e03d7062a8ef1a076edf78b0a6b1/partitioned-heat-conduction/nutils/heat.py#L103-L105

We should instead sample uexact (or its flux) defined further above:

https://github.com/precice/tutorials/blob/017b97cff4a9e03d7062a8ef1a076edf78b0a6b1/partitioned-heat-conduction/nutils/heat.py#L36

Maybe this also the reason for this FEniCS - Nutils combination issue.

Problem applies to partitioned-heat-conduction and partitioned-heat-conduction-direct.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with partitioned-heat-conduction/nutils/heat.py around lines 103-105 and compare the uexact definition near line 36. Check the corresponding Nutils participant in partitioned-heat-conduction-direct as well. Done means both cases initialize their data by sampling uexact or its flux rather than the current initialization, then the affected tutorial combinations should be verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.