precice / precice/tutorials

turek-hron-fsi3: Add FEniCS as solid participant

Open
#287 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement student
Dominant language
C
Stars
142
Forks
167
Avg merge
20h 24m
Merged PRs (30d)
11

Description

I'm adding this issue as a summary of the current state and collection of useful resources, because it just took me a bit of time to reconstruct what has happened to this case during the last few years.

  1. @richahert computed the FSI3 case with FEniCS in his thesis, section 5.2. Important: He used a linear solver. The case was contributed via https://github.com/precice/tutorials/pull/38.
  2. In https://github.com/precice/tutorials/pull/125 we decided to remove FEniCS as a solid participant from the case. Main reason: because the linear solver does not yield sufficiently accurate results.

Adding FEniCS as a solid participant would be helpful for cross-comparison to other solvers (this already helped us to debug the perpendicular flap case, see #250). FEniCS also gives very direct control over the time-stepping scheme being used, which might give us additional understanding for the case (e.g. in https://precice.discourse.group/t/turek-hron-fsi-with-openfoam-and-calculix/1001/14).

I marked this issue as a student issue, because it might be a nice thesis topic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FEniCS implementation described in the thesis, section 5.2, then read tutorials PRs 38 and 125 to understand the earlier contribution and why it was removed. Use issue #250 and the linked discussion for comparison context; done means FEniCS is restored as a solid participant with sufficiently accurate results for the FSI3 case.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.