precice / precice/tutorials

elastic-tube-1d : Unclear / wrong physicial parameters

Open
#242 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
142
Forks
167
Avg merge
20h 24m
Merged PRs (30d)
11

Description

The dimensionless stiffness is supposed to be a function of material properties and inlet velocities. In terms of code, either the stiffness is computed from these, or it is fixed and some properties or the inlet velocities should be deduced.
But here, both inlet and stiffness have an independant definition (which could be correct if these are used to compute E or h, but I don't think it's done, at least not explicitly).
I'm not confident enough with the code to say if E or h is deduced somewhere , but something definitely wrong for me is the dx = L / kappa instead of dx = L / N. Material properties should not impact the mesh size if the mesh size is another parameter (N).
Currently, N and kappa happen to have the same value so it has no impact, but this makes it quite tricky to run the tutorial with different values without creating inconsistencies.

https://github.com/precice/tutorials/blob/8e71370f0700caa25892af04145be79a3f79aff5/elastic-tube-1d/fluid-python/FluidSolver.py#L19-L29

(For reference, paper definition of the quantities can be found around page 142 of B. Gatzhammer's thesis : https://www5.in.tum.de/pub/Gatzhammer2014_preCICE.pdf)

Any insight ?

(Poke @fsimonis , I think you have some experience with this code given the history)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with fluid-python/FluidSolver.py lines 19-29 and compare the definitions of N, kappa, dx, E, h, and inlet velocities with the referenced thesis. Confirm whether the material and velocity parameters are independently defined or used to derive others; done means the tutorial's mesh and physical parameters remain consistent when N and kappa differ.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.