precice / precice/python-bindings

More strict format checking on white spaces

Open
#154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cython
Stars
30
Forks
19
PR merge metrics
No merged PRs in 30d

Description

When merging 2d36127 I realized that there are some white space changes that are somehow not taken care of by our formatter. This ambiguity always leads to a lot of manual work and I would rather have one clear rule here that is enforced by the formatter.

@IshaanDesai I have the impression that we have different VSCode settings and this might cause the white space inconsistency. Do you also observe this from time to time? Maybe in other repositories like the fenics-adapter, as well?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review commit 2d361279504192534036bb0cb4e4ec673ad7b4ff and compare the repository's formatter behavior with the VSCode settings mentioned in the issue. Define one whitespace rule, enforce it through the formatter configuration, and verify that the inconsistency no longer requires manual cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, vscode
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.