precice / precice/python-bindings

Use dockerfile from respective fork or branch for CI runs

Open
#119 0 comments 1 reaction 1 assignee View on GitHub

@IshaanDesai is already working on this.

Since Aug 12, 2021.

Dominant language
Cython
Stars
30
Forks
19
No merged PRs in 30d

Description

Currently the dockerfile used in CI runs is precice/ci-spack-pyprecice-deps-1804 which is the dockerfile on python-bindings/develop whereas actually the dockerfile from the respective fork or branch needs to be used in CI runs, for example this file from a recent PR. This happens because the file tag is hard coded in the workflow files:

https://github.com/precice/python-bindings/blob/36e4782b8460ba93ec6bfc307bef7bf281c540fa/.github/workflows/build-env.yml#L28

https://github.com/precice/python-bindings/blob/36e4782b8460ba93ec6bfc307bef7bf281c540fa/.github/workflows/build-spack.yml#L17

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.