precice / precice/case-generate
Change topology patches tag
Closed
breaking change
enhancement
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 1
Description
Short description
The tags from-/to-patch in the topology are not descriptive enough. Change them to from-/to-location-name and from-/to-location-type (i.e., from-/to-patch is renamed to from-/to-location-name and a new tag from-/to-location-type is introduced).
Details
Follow the ideas here.
This probably does not require changing the NodeCreator, except maybe for renaming of the patch objects/storage.
It should only require storing this new attribute and passing it to the adapter config file.
- Change the method
get_mesh_patch_mapinNodeCreator. It should work with the newPatchNode's exclusively, not strings. This will actually facilitate the implementation of the-location-typeas we can just store and return it there as well. - Change the mesh generation logic to split up a mesh into -{type}-extensive and -{type}-intensive.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.