preactjs / preactjs/vite-prerender-plugin

Support relative links

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
66
Forks
9
PR merge metrics
No merged PRs in 30d

Description

At the moment all links are resolved against the origin which is undesirable when using relative specifiers, as can be seen here.

We should detect relative paths and resolve them against the current origin + path. Hopefully isn't too breaking.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/plugins/prerender-plugin.js at the link-resolution logic around line 443, then inspect the linked example for the relative-specifier case. Confirm how the current origin and path are available, and verify that relative links resolve against the current page while absolute links retain their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, vite
Domain
tooling, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.