preactjs / preactjs/preact-devtools

Updates to text nodes caused by signal changes are not hightlighted

Open
#472 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
345
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Demo:

const s = signal(0);

function inc() {
  s.value++;
}

export default function App() {
  return html`
    ${s}
    <button onclick=${inc}>Increment</button>
  `;
}

When "Highlight updates" is enabled, I would expect the number to be highlighted every time it changes because I click on the button.

https://user-images.githubusercontent.com/7000710/225608523-08a31b8f-98ff-45ad-8d58-4d8b9fe1669e.mov

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied signal-based demo in the Preact DevTools extension with “Highlight updates” enabled, then trace how signal-driven text-node changes are detected. Done means the rendered number is highlighted after every button click, with the behavior checked against the provided reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.