praeclarum / praeclarum/sqlite-net

tests to shared?

Open
#487 1 comment 0 reactions 1 assignee View on GitHub

@praeclarum is already working on this.

Since Aug 5, 2017.

Feature
Dominant language
C#
Stars
4.5k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

How would you feel about moving the test cs files to a Shared Project instead of using links to files for iOS? I wanted to test a couple different bundles from SQLitePCL.raw and that would make things a bit smoother. The sqlite3.dll test would become:

image

and I would make a new test, such as SQLite3.Tests.bundle_green,

Update. I'm experimenting with this and looks like there just a few missing items in bundle_green

image

is that right?

Update2. Just an NUnit 3.5 vs 2.6.4 issue. Going backwards to NUnit 2.6.4.
Update3. Finally got everything compiling. However, tests are timing out for bundle_green. Works well for the normal test though. Probably some change I made. 📦
Update4. Expected null but got instead. Probably a difference in implementation

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.