pqrs-org / pqrs-org/cpp-spdlog
Veracode complains integral overflow on line 533 of spdlog/include/spdlog/fmt/bundled/format-inl.h
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Hi
This is the comment from Veracode for spdlog/include/spdlog/fmt/bundled/format-inl.h line 533:
borrow <<= bigit_bits;
"
Attack Vector: subNumber of Modules Affected: 1Description: This arithmetic operation results in an integer overflow error. Because the result of this calculation is larger than the maximum possible value for this data type, the result may wrap to become a very small, or negative number, therefore providing an unintended value. Integer overflows can often trigger buffer overflows, which can be exploited to execute arbitrary code."
Please verify if it's your intention or it's an bug as Veracode said.
Thanks.
David
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading spdlog/include/spdlog/fmt/bundled/format-inl.h at line 533 and reviewing the Veracode report for the borrow <<= bigit_bits operation. Determine whether the reported overflow is intentional or a defect, then validate the conclusion against the surrounding formatting logic; done means the issue is resolved with a verified result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100