postmanlabs / postmanlabs/postman-code-generators
PHP code generator does not end with ?>
Open
Nobody has claimed this yet.
codegen
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 381
- PR merge metrics
- No merged PRs in 30d
Description
When you use the code generator for PHP it generates the code without the PHP ending tag (?>).
I think it should include it. If you have existing code you can always copy it before as an individual PHP code section an it will work instanstaniously.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the PHP generator entry point in the JavaScript codebase and reproduce its output for a representative request. Done means generated PHP includes the requested closing tag and the relevant generator tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100