postalserver / postalserver/postal

Postal marks messages as checked for spam even if it errored

Open
#404 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
16.8k
Forks
1.3k
Avg merge
13d 7h
Merged PRs (30d)
2

Description

As per #402 it seems messages are reported as checked and then publicly reported as "not spam" even if the spam check failed.

I would suggest a check needs adding here so that messages are marked as not inspected if a timeout or error has occurred
https://github.com/atech/postal/blob/6f29bc8d3f6f197d142724a7baee7376ff5fe8aa/lib/postal/message_db/message.rb#L499

I may be able to test and pull request this in later.

I presume a similar issue affects the virus check also.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.