posit-dev / posit-dev/shinylive
Registering service worker ES module shinylive-sw.js fails behind authentication
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 251
- Forks
- 25
- Avg merge
- 19m
- Merged PRs (30d)
- 2
Description
I am hosting a shinylive app on self hosted GitHub Enterprise. All HTTP requests to GitHub need to be authenticated. IE a valid session cookie needs to be included with the HTTP request.
Using macOS Chrome Version 113.0.5672.92 (Official Build) (arm64) I have this experience -
The issue is that load-shinylive-sw.js cannot register shinylive-sw.js because the HTTP request forshinylive-sw.js does not include the session cookie.
All other HTTP requests include the session cookie.
I cannot reproduce this on Safari.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the service-worker registration in load-shinylive-sw.js and the requested shinylive-sw.js resource. Reproduce the failure in Chrome 113 against authenticated GitHub Enterprise and compare its request with the other cookie-bearing requests. Done means the service worker registers successfully while the valid session cookie is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100