posit-dev / posit-dev/shinylive

should make target dist work without making "all" before

Open
#127 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
251
Forks
25
Avg merge
19m
Merged PRs (30d)
2

Description

Is the make target dist intended to be built without making all before? I tried building the dist files, to test deploying a shinylive app with the newest assets. It seems to be necessary to build the make target all before making dist.

If this is intended behavior, please clarify in the build instructions in the README.md or if not add the necessary dependencies to the dist target.

make submodules
make dist

Fails with error:

node_modules/.bin/tsx scripts/build.ts
make: node_modules/.bin/tsx: Command not found
make: *** [Makefile:203: buildjs] Error 127

Works:

make submodules
make all
make dist

All in all, the build process is really well setup and building worked quickly, so this is probably a minor issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the dist and buildjs targets around Makefile:203, then inspect scripts/build.ts and the README.md build instructions. Run the reported make submodules followed by make dist to reproduce the missing node_modules/.bin/tsx error. Done means dist works from the documented command sequence, or the README clearly states that make all is required.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.