posit-dev / posit-dev/shiny-vscode

Remove unnecessary `onCommand` events from `package.json`

Open
#35 0 comments 0 reactions 1 assignee View on GitHub

@gadenbuie is already working on this.

Since Apr 22, 2024.

Dominant language
TypeScript
Stars
37
Forks
12
Avg merge
2d 9h
Merged PRs (30d)
4

Description

https://github.com/posit-dev/pyshiny-vscode/blob/3635a936a35859af82b3a02bf8246142d0631635/package.json#L18-L24

The onCommand events are flagged by linters:

This activation event can be removed for extensions targeting engine version ^1.75 as VS Code will generate these automatically from your package.json contribution declarations.

I think this is safe: VS Code 1.75 was released in January 2023.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.