posit-dev / posit-dev/rsconnect-python
fix pyright errors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 37
- Forks
- 28
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 7
Description
pyright was added to make lint in #567, but it was immediately suppressed with a leading - in the Makefile so it doesn't fail the build. Currently there are 110 pyright errors. I believe these are all things that we at one point intended to enforce but are not currently doing so.
This issue is to do cleanup of those 110 errors, and then turn on real enforcement by removing the -
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Makefile target at lines 59-64 and run the existing lint command to collect the 110 pyright errors. Work through the reported Python files, then remove the leading - from the pyright command. Done means the cleanup is complete and make lint enforces pyright successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100