posit-dev / posit-dev/rsconnect-python

Should remove `actions.deploy_python_fastapi`

Open
#573 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
37
Forks
28
Avg merge
1d 3h
Merged PRs (30d)
7

Description

The function actions.deploy_python_fastapi is a deprecated code path, and many similar functions were removed in #566. This function was kept because it is used by vetiver here.

At some point, we should:

  • Replace actions.deploy_python_fastapi with one that calls the python fastapi deployment code in main.py.
  • Update vetiver to call the function from main.py.
  • After some time, remove actions.deploy_python_fastapi.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating actions.deploy_python_fastapi and the Python FastAPI deployment code in main.py. Then inspect vetiver/rsconnect.py at the linked call site to understand the external caller. Done means vetiver uses the main.py entry point and the deprecated actions function can be removed after the transition period.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.