posit-dev / posit-dev/rsconnect-python
remove `conda_mode` as a required argument for `deploy_python_fastapi`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 37
- Forks
- 28
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 7
Description
as of v1.21.0, conda_mode is no longer supported. However, it is currently still a required argument for deploy_python_fastapi. It might make more sense for users to make this optional/raise a deprecation warning/as a kwarg since it can no longer be used.
CC: @tdstein @mmarchetti
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at rsconnect/actions.py:854 and read the deploy_python_fastapi entry point and its surrounding argument handling. Done means conda_mode is no longer required, with the chosen optional, deprecation-warning, or keyword-argument behavior made explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100