posit-dev / posit-dev/py-shiny

Set default `static_assets` path to the same dir as the file

Open
#526 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.8k
Forks
135
Avg merge
2d 18h
Merged PRs (30d)
21

Description

App() takes a configurable static_assets path, but the default is None, which meant that I seemed to be littering my code with Path(__file__).parent / filename after being surprised that a file wasn't found. How about making the default be Path(__file__).parent?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the App() definition and the existing handling of its configurable static_assets path. Check the related tests, then verify that the default resolves relative to the file as requested and that explicit static_assets values still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.