posit-dev / posit-dev/py-shiny
Should we add a `for` attribute for the label in `input_checkbox()`?
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 135
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 21
Description
Looking at the structure for an input_checkbox, it does not have the for attribute for the label. Should we add this?
Related:
- R
checkboxInput()(missing label'sfor): https://github.com/rstudio/shiny/blob/ed6022e3f2ea2a0c7dd8333af1e2466f0aeffcc5/R/input-checkbox.R#L30-L44 - py-shiny
input_checkbox()(missing label'sfor): https://github.com/rstudio/py-shiny/blob/165d698871a4e63f83d0943b881ffb78e89f6f74/shiny/ui/_input_check_radio.py#L60-L67 - py-shiny
input_switch()(has labelforattr): https://github.com/rstudio/py-shiny/blob/165d698871a4e63f83d0943b881ffb78e89f6f74/shiny/ui/_input_check_radio.py#L131
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in shiny/ui/_input_check_radio.py at input_checkbox(), then compare its label structure with input_switch(), which the issue links as having a label for attribute. Confirm how the checkbox id and label target are represented, then verify that the rendered checkbox label is associated with its input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100