posit-dev / posit-dev/py-shiny
reload does not work when launched with option `--log-level error`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 135
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 21
Description
First of all, mega interesting project! Thank you :)
Launch command:
shiny run --reload --log-level error
Result:
When code changes, web page gets greyed out and not responsive.
Possible origin of the problem:
https://github.com/rstudio/py-shiny/blob/f2689a38a97f7e37030efbaf6f6ebb79f13faa8f/shiny/_autoreload.py#L56
is not called when log-level is above info, because of
https://github.com/rstudio/py-shiny/blob/f2689a38a97f7e37030efbaf6f6ebb79f13faa8f/shiny/_main.py#L249
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with shiny/_autoreload.py at line 56 and shiny/_main.py at line 249, tracing how the --log-level error path affects autoreload. Reproduce with shiny run --reload --log-level error, then verify that changing code triggers a responsive page reload rather than leaving the page greyed out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 40/100