posit-dev / posit-dev/py-shiny
bug(bookmark): When calling `on_bookmarked()`, we should set the session context for SessionProxy
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 135
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 21
Description
cc @gadenbuie
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the on_bookmarked() callback and the SessionProxy implementation, then trace how session context is established for callbacks. Confirm the expected context behavior from nearby callback handling and add or update a focused test showing that SessionProxy has the correct session context when on_bookmarked() runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100