posit-dev / posit-dev/py-shiny
[Feature]: When no on_bookmarked handlers have been registered, display notification and update clipboard with url
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 135
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 21
Description
Category
Input/Output
Scope
Quality of Life
Problem
In R shiny, it currently displays a modal in this situation. I do not like the modal and would prefer a less invasive option.
Solution
I propose that a notification is shown and the user's clipboard is updated with the URL value.
Alternatives (Optional)
- Showing a modal: It blocks the whole screen. When you click "bookmark", it is fair that you want the URL now. Not trying to exit a modal to get back to your app or having a modal block your app. I want the url now and without any effort.
- Throw an error: This would cause the app to crash. Crashing is bad Mkay.
- Do nothing: Worst of all three is to do something where you expect a reaction and nothing happens. This is difficult to debug and very frustrating to figure out.
Example (Optional)
Impact (Optional)
No response
Contribution? (Optional)
None
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code path used when no on_bookmarked handlers are registered and the existing modal behavior. Read the notification and clipboard integration points, then verify that bookmarking shows a notification and copies the URL without blocking the app.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100