posit-dev / posit-dev/ptd

Azure external-dns deploys unconditionally; external_dns_enabled flag only honored on AWS

Open
#314 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
7
Forks
2
Avg merge
1d 15h
Merged PRs (30d)
3

Description

Summary

On Azure (AKS), external-dns is deployed unconditionally by the helm step. The external_dns_enabled configuration flag is only consulted on the AWS code paths; the Azure path (lib/steps/helm_azure.go) installs external-dns with no guard.

Impact

  • Setting external_dns_enabled: false has no effect on Azure — external-dns (its namespace, the azure-config-file secret, managed identity, DNS-zone role assignment, and HelmChart) is still created.
  • Surfaced during attestation review: the generated doc reported "External DNS disabled" while the resources were present. The attestation prose has since been corrected to reflect Azure's actual behavior, but the underlying deploy behavior is unchanged.

Suggested fix

Either honor external_dns_enabled on the Azure path (guard the external-dns install in helm_azure.go), or treat the flag as AWS-only by design and document that.

References

  • lib/steps/helm_azure.go — Azure external-dns deployed unconditionally
  • lib/steps/clusters_aws.go, lib/steps/persistent_aws.go — where the flag is honored (AWS)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/steps/helm_azure.go and compare its external-dns handling with the flag checks in lib/steps/clusters_aws.go and lib/steps/persistent_aws.go. Confirm the intended Azure behavior before changing it; done means Azure no longer contradicts the documented meaning of external_dns_enabled, including the listed external-dns resources.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, go, helm, kubernetes
Domain
cloud, devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.