posit-dev / posit-dev/positron
Top bar does not update based on custom dark/light theme
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 184
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 206
Description
Originally posted by @juliasilge in #3799:
When we investigate what is going on here, let's also look at problems of the category described in https://github.com/posit-dev/positron/discussions/7319:
It turns out this is not our custom components, but rather a problem from upstream that is worse in Positron because of what we put in those bars. This screenshot (thanks, @statik!) shows Positron in the background and VS Code in the foreground:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the custom dark/light theme behavior in Positron and compare it with the VS Code screenshot in this issue. Read the linked discussion #7319 and the original context in issue #3799 to understand the upstream problem. Done means the top bar updates correctly when the custom theme changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100