posit-dev / posit-dev/positron
Add UI affordance for refreshing plots
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 184
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 206
Description
From discussion in #8112
I know the toolbar is a lil crowded, but what would folks think of having a button on there that performs a plot redraw?
- button lights up when the plot "needs redrawn" (its current rendered size is not the size recommended by the size policy)
- button can be used at any time to force a redraw
- button is latching or has a drop menu to control redraw policy inline (w/o dipping into Settings)
💬
maybe a "Refresh" button works in this scenario, as in, "refresh (the size of) the plot"?
💬
There does happen to be an unimplemented refresh plot action: https://github.com/posit-dev/positron/blob/main/src/vs/workbench/contrib/positronPlots/browser/positronPlotsActions.ts#L180
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the unimplemented refresh plot action in src/vs/workbench/contrib/positronPlots/browser/positronPlotsActions.ts around line 180, then read discussion #8112 for the proposed toolbar behavior. Determine how the refresh control should expose redraw and redraw-policy behavior; done means the plot toolbar provides the agreed affordance and its behavior is covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100