posit-dev / posit-dev/positron
Python and R session objects have leaked disposables
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 184
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 206
Description
Python and R session objects have leaked disposables (the event emitters and listeners). We should store those in an array and dispose them on dispose().
I'm not sure whether there are any downstream issues caused by this so it might be harmless atm.
Originally raised in https://github.com/posit-dev/positron/pull/6714/files#r1990714738.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the Python and R session object implementations and the discussion linked from pull request 6714, then trace how their event emitters and listeners are created. Confirm which disposables are currently left behind and verify that dispose() releases them all; the issue does not name specific files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, r, typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100