posit-dev / posit-dev/positron
Support longer text in buttons on Positron modals
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 184
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 195
Description
Capturing a recent Slack conversation inspired by #5648. In that PR, at first I used vscode.window.showWarningMessage(), which looked like this, for modal: true vs. false:
This approach was ultimately rejected in favor of using Positron's API for this, in order to accomodate Workbench. Here's the current result with positron.window.showSimpleModalDialogPrompt():
There's definitely room for improvement here and @softwarenerd is game to implement it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the implementation of positron.window.showSimpleModalDialogPrompt() and the modal shown in the issue. Compare the current button text behavior with the screenshots, then determine and verify how longer button labels should be supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100