posit-dev / posit-dev/positron

VS Code editor sends incorrect range params to LSP when special characters are in the line

Open
#497 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: editor
Dominant language
TypeScript
Stars
4.3k
Forks
184
Avg merge
1d 9h
Merged PRs (30d)
195

Description

If a line has a character code point > U+FFFF, e.g. an emoji, the range params sent to the LSP for various operations, like hover, are invalid and beyond the range of the line length (i.e. the column number is greater than the logical line length).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the VS Code editor path that builds LSP range parameters for operations such as hover. Reproduce the issue with a line containing a character above U+FFFF and inspect the range sent to the LSP; done means the column remains valid for the logical line length.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.