posit-dev / posit-dev/positron
family field seems to get fonts in a different way than VS Code
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 184
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 206
Description
System details:
M3 Pro Macbook
System Version: macOS 14.5 (23F79)
Kernel Version: Darwin 23.5.0
Positron and OS details:
Positron Version: 2024.07.0 (Universal) build 125
Code - OSS Version: 1.91.0
Commit: cae4905332a0f41a6233e196b48a6679b832000a
Date: 2024-08-01T00:27:06.019Z (4 days ago)
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0
Describe the issue:
In VSCode setting my font to "Fira Code" works fine. The font successfully changes to Fira Code. In Positron I had to specify the font, i.e "FiraCode Nerd Font Mono" for the font to change
Steps to reproduce the issue:
I am not sure how to reproduce. This might be a system specific issue, but given it works differently in VS Code I am hoping the explanation above might give a hint
Expected or desired behavior:
"Fira Code" should be a valid font family
Were there any error messages in the UI, Output panel, or Developer Tools console?
This is the only output I get when I change between "Fira Code" and "FiraCode Nerd Font Mono"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Start by reproducing the font-family setting on macOS and compare Positron's behavior with VS Code; done means the "Fira Code" family is accepted and applied without requiring "FiraCode Nerd Font Mono".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, macos, typescript, vscode
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100