posit-dev / posit-dev/positron

minor UI nit: allow space bar to select option in modal dialog

Open
#383 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui
Dominant language
TypeScript
Stars
4.3k
Forks
184
Avg merge
1d 9h
Merged PRs (30d)
195

Description

For example, in the Clear All Environment Objects dialog:

Screenshot 2023-04-03 at 2 15 32 PM

For macOS native dialogs, Spacebar is used to select the button that has keyboard focus; Enter is used to select the default button. Should we match that behavior in our home-brewed dialogs as well?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Clear All Environment Objects modal dialog and inspecting how its focused buttons handle keyboard input. Confirm the existing Enter behavior, then make Space select the focused button while Enter continues to select the default button; verify this in the dialog and other home-brewed modal dialogs.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.