posit-dev / posit-dev/positron

Update preformatted text color

Open
#3,531 1 comment 0 reactions 1 assignee View on GitHub

@nstrayer is already working on this.

Since Jun 18, 2024.

area: ui
Dominant language
TypeScript
Stars
4.3k
Forks
184
Avg merge
1d 9h
Merged PRs (30d)
195

Description

Currently, preformatted/code in non-editor contexts is given a light red color which has a negative context. We should change this to be something a bit more friendly.

We already do this for the modal dialogs (see #3507) but it would be better to simply update the textPreformat.foreground token to something so we get better behavior elsewhere.

The code that will need to change is https://github.com/posit-dev/positron/blob/c50dcf9a9a8b6f6178c3ac2a55cc699a5f3d1c16/src/vs/platform/theme/common/colors/baseColors.ts#L67-L70

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.