posit-dev / posit-dev/positron
ark: Behaviour with redundant `open_comm` messages
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.3k
- Forks
- 183
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 206
Description
When this happens, positron functionality is limited. We no longer receive set-console-width events for instance.
[R] 2024-01-03T15:26:16.633372000Z [ark-unknown] ERROR crates/ark/src/frontend/frontend.rs:66: Error receiving Positron event; closing event listener: RecvError
A RecvError indicates the channel is closed, which can only occur if all senders have been dropped, but that doesn't appear to be the case. Puzzling.
This unexpected channel closing is what caused the infinite logs issue that was fixed in https://github.com/posit-dev/amalthea/pull/176
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in crates/ark/src/frontend/frontend.rs at the Positron event listener and examine how redundant open_comm messages relate to the RecvError and closed channel. Use the linked pull request #176 for context; done means the listener remains functional, set-console-width events continue arriving, and the unexpected channel-closing logs do not recur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100