R: Make custom `notIn` conditions

Open
#1,679 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
vscode
Domain
tooling

Research direction

Start with the linked extensions/positron-r/language-configuration/r-language-configuration.json entry and review how its notIn values are consumed. Determine how an extension could configure a condition beyond string and comment, then verify that a condition such as backticks prevents autoclosing as intended.

Written by the indexing model from the issue text.

Description

lang: r

In our language configuration, we set some autoclosing brackets to not autoclose (i.e. notIn) in some conditions:

https://github.com/posit-dev/positron/blob/0d5d67e217d6b03ea51a481a84c390cf98f7bbc0/extensions/positron-r/language-configuration/r-language-configuration.json#L14

Right now, we only use the vscode options of "string" and "comment". We eventually will likely want to provide other conditions, for example, not between backticks like `[`. It is possible for extensions to provide these custom notIn conditions.

Dominant language
TypeScript
Stars
4.3k
Forks
184
Avg merge
1d 9h
Merged PRs (30d)
195

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from posit-dev/positron

All issues in posit-dev/positron

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.