Remove the sqlglot<30.18 dev constraint once ibis fixes duckdb create_table
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 120
- Forks
- 9
- Avg merge
- 11d 6m
- Merged PRs (30d)
- 2
Description
Goal
The sqlglot<30.18 entry in the dev dependency group of pyproject.toml
is removed, and Test Examples / Run benchmarks stay green on the newest
sqlglot.
Done when an ibis release fixes the nameless DROP VIEW in the duckdb
create_table in-memory branch (tracked upstream at
https://github.com/ibis-project/ibis/issues/12124), ibis-framework is
bumped to that release, and the constraint line plus its comment are gone.
Why
The constraint is a workaround for an ibis bug, not a requirement of orbital.
Keeping it after the upstream fix would silently hold development
environments on an old sqlglot.
References
pyproject.toml([dependency-groups] dev,sqlglot<30.18)- Issue: Examples and benchmarks CI fail on main: ibis 12.0.0 incompatible with sqlglot 30.18.0 #136
- Upstream: https://github.com/ibis-project/ibis/issues/12124
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the [dependency-groups] dev section in pyproject.toml and confirm which ibis release includes the upstream fix for the nameless DROP VIEW in DuckDB create_table. After ibis-framework is bumped, remove the sqlglot<30.18 entry and its comment, then verify that Test Examples and Run benchmarks pass with the newest sqlglot.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sql
- Domain
- build-system, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100