posit-dev / posit-dev/images-shared

Improve dgoss test collection for image types

Open
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cvp:0 docker docker/tools tdp:2 tech debt
Dominant language
Python
Stars
2
Forks
0
Avg merge
4d 13h
Merged PRs (30d)
22

Description

Ideally, users shouldn't need to be notified for "expected" test skips. For instance, min images simply won't ever run tests that appear in std for Python and R installations. These tests should not only be skipped on min, but shouldn't even show in the test counts for min. By better separating the tests, we should be able to prevent missing unintentional skips should they ever happen.


It could be useful to include the list the skipped tests when the `--verbose` flag is set.

This also makes me think about whether we should break up the tests into sections or files that are included conditionally instead of peppering this everywhere
    skip: {% raw %}{{ if eq .Env.IMAGE_TYPE "min" }}true{{ else }}false{{ end }}{% endraw %}

Originally posted by @bschwedler in https://github.com/posit-dev/images-shared/issues/123#issuecomment-2704258403

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the dgoss test definitions and the existing IMAGE_TYPE skip conditions shown in the issue. Compare collection and reporting for min and std images across Python and R installations; done means expected skips no longer appear in min test counts, with verbose skipped-test output considered if the existing test runner supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, r
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.