posit-dev / posit-dev/ggsql

More informative errors

Open
#84 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

messages
Dominant language
Rust
Stars
554
Forks
30
Avg merge
17h 27m
Merged PRs (30d)
8

Description

Not sure how easy/feasible this is, but it would be great if we could probably more feedback if parsing fails.

ggsql parse "SELECT sex, class, COUNT(*) AS total, SUM(survived) AS num_survived FROM titanic WHERE sex IS NOT NULL AND class IS NOT NULL GROUP BY sex, class VISUALISE class AS x, sex AS y, num_survived/total AS fill, total AS size DRAW rect LABEL title => 'Mosaic Plot: % Survived by Sex and Class', x => 'Class', y => 'Sex', fill => 'Survival Rate', size => 'Group Size'"
Parse error: Parse error: Parse tree contains errors

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the ggsql parse command shown in the issue and trace the parsing entry point that produces Parse tree contains errors. Read the parser-related code and existing error-handling tests, if present. Done means parse failures provide more useful feedback than the current generic error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.