posit-dev / posit-dev/ggsql

Should we enforce an order of clauses?

Open
#61 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

syntax
Dominant language
Rust
Stars
554
Forks
30
Avg merge
17h 27m
Merged PRs (30d)
8

Description

Currently the clauses within a DRAW directive have a fixed order and parsing will fail if it isn't honoured. There are no technical reasons why we can't lift that restriction, but we may want enforce it anyway. SQL has a set clause order so that would fall in line with that, and it will also make it easier to read others code if every query had the same order.

Some question applies elsewhere and I think we should generally apply the decision to all aspects of the api. Either fixed order or none

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the DRAW directive, clause parsing, and the broader API, but no file or test entry point. First locate the DRAW parser and tests covering clause order, then resolve whether the API should require a fixed order across directives; done means the chosen policy is consistently implemented and tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.