posit-dev / posit-dev/ggsql

Missing graticules when scales are missing

Open
#538 1 comment 0 reactions 1 assignee View on GitHub

@teunbrand is already working on this.

Since Sep 9, 2026.

Dominant language
Rust
Stars
554
Forks
30
Avg merge
17h 27m
Merged PRs (30d)
8

Description

The work in #492 has a regression when only a geometry layer is present and positional scales have not been explicitly provided:

let lon_breaks = match scales.iter_mut().find(|s| s.aesthetic == "pos1") {
    Some(s) => { resolve_map_scale(s, geo_bbox.xrange()); s.numeric_breaks() }
    None => Vec::new(),
};

fails to find the non-existing pos1 scale that hasn't been created because only geometry has been mapped. We need to create default positional scales when they are missing from the mapping so that they can provide default breaks etc

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.