Vega-Lite writer: build_discrete_facet_label_expr is unreachable
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 554
- Forks
- 30
- Avg merge
- 17h 27m
- Merged PRs (30d)
- 8
Description
build_discrete_facet_label_expr (src/writer/vegalite/mod.rs:964) is reached from apply_facet_label_renaming only when index_map is empty and the scale is not binned. Facet ordering converts every discrete facet column to integer sort indices and routes it through build_indexed_facet_label_expr instead, so that combination no longer occurs — the branch at src/writer/vegalite/mod.rs:744 looks dead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/writer/vegalite/mod.rs, reading apply_facet_label_renaming around line 744 and build_discrete_facet_label_expr around line 964. Trace the index_map and binned-scale conditions to confirm the branch is unreachable. Done means the dead path is removed or otherwise resolved without changing reachable facet-label behavior, with the relevant test suite passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100