posit-dev / posit-dev/ggsql

Improvement to FILTER

Open
#200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

reader
Dominant language
Rust
Stars
554
Forks
30
Avg merge
17h 27m
Merged PRs (30d)
8

Description

Currently filter is parsed verbatim to a WHERE clause in the layer query. This can force some rather awkward syntax like FILTER revenue = (SELECT max(revenue) FROM sales) rather than FILTER revenue = max(revenue)

We should think about how this syntax can be improved

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining how FILTER is parsed and passed into the layer query's WHERE clause, using the two syntax examples in the issue as the initial cases. Done means the proposed FILTER syntax is defined clearly and produces the intended query without requiring the awkward subquery form.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.