posit-dev / posit-dev/connectapi

Clean up `bundle_path()` error handling

Open
#138 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue :heart: help wanted :heart:
Dominant language
R
Stars
54
Forks
27
Avg merge
1d 3m
Merged PRs (30d)
1

Description

  • check that manifest.json is in the tar archive:
"./manifest.json" %in% utils::untar(filepath, list = TRUE)
  • check that the filetype is a .tar.gz? Not sure how to do this...
  • check that file actually exists

Could put some of these checks into the Bundle R6 class if we want too...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at bundle_path() and inspect how it currently handles the filepath and archive contents; review the Bundle R6 class if those checks belong there. Done means the requested manifest, archive-type, and file-existence cases are handled with clear errors, with tests covering the checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.